feat(coverage): Demangling of Java function names in coverage results #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
vogelsgesang
changed the title
This commit adds demangling support for Java. I couldn't find any good third-party library for this, so I quickly implemented my own, based on https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.3.2 It might still be have a couple of bugs, but at least for my simple smoke tests, demangling seems to work just fine.
vogelsgesang
force-pushed
the
avogelsgesang-coverage-1
branch
from
566b444
to
67a1eb6
Compare
vogelsgesang
changed the title
11 tasks
|
Gentle ping 🙂 |
cameron-martin
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds demangling support for Java. I couldn't find any good
third-party library for this, so I quickly implemented my own, based on
https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.3.2
It might still be have a couple of bugs, but at least for my simple
smoke tests, demangling seems to work just fine.
Works towards #362